Improve screen reader accessibility in web UI#3
Open
odium1963 wants to merge 1 commit intoFave42:masterfrom
Open
Improve screen reader accessibility in web UI#3odium1963 wants to merge 1 commit intoFave42:masterfrom
odium1963 wants to merge 1 commit intoFave42:masterfrom
Conversation
- Replace ui.aggrid with ui.table so NVDA can read episodes in browse mode using native HTML table semantics - Replace the parallel-downloads slider with a number input, which screen readers handle natively without extra ARIA wiring - Hide Quasar's internal q-focus-helper spans from the accessibility tree (they have tabindex="-1" and no label, causing NVDA to announce an unlabeled button before every interactive element) - Restore a visible focus ring for sighted keyboard users via :focus-visible CSS so removing q-focus-helper doesn't regress keyboard navigation visually Co-Authored-By: odium1963 <odium71499@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ui.aggridwithui.tablefor the episode listq-focus-helperspans from the accessibility tree:focus-visibleCSSWhy
Tested with NVDA on Windows. Three issues were found:
Episode table unreadable — AG Grid uses div-based custom ARIA that NVDA frequently fails to parse in browse mode.
ui.tablerenders a native<table>element with proper<thead>/<tbody>semantics that NVDA reads correctly.Slider inaccessible — Quasar's
QSliderwasn't being announced correctly by NVDA in either browse or focus mode. A standard<input type="number">works out of the box with all screen readers.Unlabeled button announced before every interactive element — Quasar adds a
<span class="q-focus-helper" tabindex="-1">inside every button, checkbox, and slider for its focus ring effect. Because it hastabindex="-1", NVDA announces it as an unlabeled interactive element in browse mode. Settingdisplay: noneremoves it from the accessibility tree entirely. A:focus-visibleCSS rule on the parent elements restores the visual focus indicator for sighted keyboard users.Test plan
🤖 Generated with Claude Code